Add support for require.resolve#1216
Add support for require.resolve#1216vikr01 wants to merge 1 commit intoimport-js:mainfrom vikr01:feature/require-resolve
Conversation
ljharb
left a comment
There was a problem hiding this comment.
This is a breaking change, however, unless it’s under an option. Can we make that change?
|
@ljharb was thinking the same thing, yeah I'll make a version using an option |
|
Closing in favor of #1217 |
|
I'm going to keep the two in sync; orphaned PRs clutter the log. |
|
@ljharb why is this a breaking change if feels semver minor to me, in that it is sortof a bugfix, but broad enough that it qualifies as an added feature. I'd prefer this over require-ing (pun intended) users to discover and enable this behavior. |
|
@benmosher There may be some who are using |
|
fair enough, I guess can just try to make the note to bump it to on-by-default in v3. |
|
@benmosher new warnings are almost always a breaking change. |
Closes #585
Related to discussion in #1035 (link to comment).
So far I've only added
require.resolveforcommonjswithno-unresolved, let me know if I should add it anywhere else.