Add index to name of refactor diff files to keep track of order of application #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
reviewed
Dec 3, 2025
kkysen
approved these changes
Dec 3, 2025
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
LGTM, but can you use $(cmd) instead of `cmd`? Also, the diff files have an empty line at the top. Though that might not be from this.
Contributor
Author
The empty line is probably from c2rust-refactor, not sure what to do about that. |
ahomescu
force-pushed
the
ahomescu/order_refactor_diffs
branch
from
6a1b639 to
063e54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order which we apply the transforms in is relevant, so prepend an index to the diff name. This follows the style of git patches:
0000_first_patch.diff,0001_second_patch.diff, etc...