Skip to content

Conversation

@dianapaula19
Copy link
Contributor

@dianapaula19 dianapaula19 commented Apr 28, 2025

Fixes: #89 and #90

This PR create two pipelines:

  • one for publishing a new version to PyPi with two steps:
    • validate-release: validates the release for each of the following python versions: 3.9, 3.10, 3.11, 3.12 (similar to the ci pipeline)
    • build-and-publish: builds the project, validates the files using twine, and published the built files to PyPi
      The pipeline is triggered when a new release is created and the second step has to be approved by someone from the pypi env approvers list.
  • one for publishing the docs to https://imedslab.github.io/solt/ whenever there's a change to /doc

@dianapaula19 dianapaula19 changed the title Add production workflow file Add production release workflow file Apr 28, 2025
@dianapaula19 dianapaula19 changed the title Add production release workflow file Add production release and build documentation workflow files Apr 28, 2025
@dianapaula19 dianapaula19 requested a review from Copilot April 28, 2025 01:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new GitHub Actions workflows: one to build and deploy documentation to GitHub Pages upon changes in the doc/ directory, and another to automate the PyPI release process when a new release is published.

  • Added a documentation build and deploy workflow triggered on pushes to the master branch affecting the doc/ directory.
  • Added a production release workflow that validates the release across multiple Python versions and then builds and publishes the release to PyPI.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/update-docs.yaml Defines the documentation build and deploy pipeline.
.github/workflows/prod-release.yaml Defines the PyPI release pipeline with validation steps.
Comments suppressed due to low confidence (2)

.github/workflows/update-docs.yaml:7

  • [nitpick] The workflow is set to trigger on pushes to the 'master' branch. Verify that 'master' is indeed the intended branch name, especially if the repository's default branch might be named differently.
branches:

.github/workflows/prod-release.yaml:64

  • [nitpick] The build-and-publish job uses a fixed Python version (3.11) while the validate-release job tests multiple versions. Confirm that using 3.11 exclusively for building and publishing is intentional.
python-version: "3.11"

@dianapaula19 dianapaula19 requested a review from lext April 28, 2025 07:30
@dianapaula19 dianapaula19 merged commit f2cc03a into master Apr 28, 2025
4 checks passed
@lext lext deleted the prod-release-workflow branch May 3, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix deployment to PyPi

2 participants