Skip to content

Conversation

@imashnake0
Copy link
Owner

@imashnake0 imashnake0 commented Mar 5, 2023

Dynamic Media Page. Changes to material-color-utilities were stolen from #90 and material-foundation/material-color-utilities#76 (thank you @DatL4g!).

Summary of changes:

  1. Cherry-picked changes in material-color-utilities from Generate a dynamic theme based on media color #90.
  2. Used ThemeUils to apply dynamic color scheme.
  3. Fixed bottom padding.

Tested changes:
Media pages use different color schemes!

boswelja and others added 7 commits March 4, 2023 23:59
The color at the bottom was different because of the padding and background modifier order.
The background color was different at the bottom for short media screens.
@imashnake0 imashnake0 added the enhancement Enhancement label Mar 5, 2023
@imashnake0 imashnake0 requested a review from boswelja March 6, 2023 05:33
@imashnake0 imashnake0 merged commit 3707a3a into main Mar 13, 2023
@imashnake0 imashnake0 deleted the dynamic-media-page branch March 13, 2023 05:45
imashnake0 added a commit that referenced this pull request Apr 26, 2023
Chages to `MediaPage` were made in #96.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants