corrects and improves color coding of events in offering calendar and learner-group calendar. #9109
Conversation
… blocked-time class to them.
…tyle sub-group based events differently.
we don't need the flexibility of passing arbitrary CSS classes to the event class, but we need to be able to flag an event to show itself as blocked time on the calendar grid.
…ged to show blocked time.
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
fixes a minor bug that only got unearthed when shuffling code around.
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Visual Diff Results🔍 Comparing screenshots... Baseline: /home/runner/work/frontend/frontend/baseline-frontend 📊 Results: ❌ Visual differences detected. 📄 Report generated: /home/runner/work/frontend/frontend/visual-diff-9109/index.html Download the results. |
jrjohnson
left a comment
jrjohnson
left a comment
There was a problem hiding this comment.
Awesome. I'm surprised no visual diff tests came back on this. Might be worth adding some screenshots to these tests as this is tough to test otherwise.
| this.clickable | ||
| ' clickable' | ||
| }}" | ||
| }}{{this.additionalCssClasses}}" |
There was a problem hiding this comment.
Why the extra get value here and not just put this in a if like clickable? Or maybe merge clickable into the additionalCssClasses?
2 participants
fixes ilios/ilios#6888