-
Notifications
You must be signed in to change notification settings - Fork 27
Replace Visual Diff Comments #9104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Found a way nicer actions based way to create these comments and then attach a marker to them so if we re-run a PR we can replace the comment instead of creating it again.
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔍 Visual Diff Results🔍 Comparing screenshots... Baseline: /home/runner/work/frontend/frontend/baseline-frontend 📊 Results: ✅ All checks passed! 📄 Report generated: /home/runner/work/frontend/frontend/visual-diff-9104/index.html Download the results. |
| run: | | ||
| JSON='${{ steps.data.outputs.result }}' | ||
|
|
||
| ISSUE_NUMBER="$(echo "$JSON" | jq -r '.issue_number')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use jq in a github workflow script? I didn't think that was standard like awk, sed, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of thought of it that way. Always seems to be there when I want it. I'm this case it's one of the installed tools: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#tools
| actions: read | ||
| pull-requests: write | ||
| env: | ||
| MARKER: "<!-- visual-diff-results -->" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i accept this.
Found a way nicer actions based way to create these comments and then attach a marker to them so if we re-run a PR we can replace the comment instead of creating it again.