Skip to content

Conversation

@michaelchadwick
Copy link
Contributor

Fixes ilios/ilios#5602
Fixes ilios/ilios#5603

This also makes the yes/no/trash icons vertically centered in editinplace contexts, in general, as well as in this specific context.

@netlify
Copy link

netlify bot commented Jan 28, 2026

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit b4461d1
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/697954a2e376fb0007bbdcc7
😎 Deploy Preview https://deploy-preview-9096--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

🔍 Visual Diff Results

🔍 Comparing screenshots...

Baseline: /home/runner/work/frontend/frontend/baseline-frontend
Candidate: /home/runner/work/frontend/frontend/candidate-frontend
Output: /home/runner/work/frontend/frontend/visual-diff-9096

📊 Results:
Total images: 752
With differences: 8
Identical: 744
Removed: 0
Added: 0

❌ Visual differences detected.

📄 Report generated: /home/runner/work/frontend/frontend/visual-diff-9096/index.html

Download the results.

Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dartajax dartajax added the run ui tests Run the expensive UI tests label Jan 31, 2026
@jrjohnson jrjohnson removed their request for review February 2, 2026 17:12
Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight visual change - it looked weird in the PR but better in real-life - updated user guide screen shots wouldn't hurt either - will ticket that too for me deal with

@dartajax
Copy link
Member

dartajax commented Feb 3, 2026

Visual DIff reviewed as well - gonna get this one in there.

@dartajax dartajax merged commit 44520dc into ilios:master Feb 3, 2026
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run ui tests Run the expensive UI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Another Minor Alignment Issue - Slightly Floating Competency Label Slight Trash Can Vertical Justification Issue - Competencies School level

3 participants