LearnerGroup Calendar event and tooltip improvements #9086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
dartajax
added
run ui tests
michaelchadwick
force-pushed
the
frontend-6574-lg-calendar-improvements
branch
from
6e07fad to
92249c9
Compare
Member
|
Some legit test failures here, pulled off the UI label as those won't ever pass if the CI ones are failing. |
…p extra weird space
Contributor
Author
|
Checking the tests now... |
michaelchadwick
force-pushed
the
frontend-6574-lg-calendar-improvements
branch
from
92249c9 to
e1a23f6
Compare
Contributor
🔍 Visual Diff Results🔍 Comparing screenshots... Baseline: /home/runner/work/frontend/frontend/baseline-frontend 📊 Results: ❌ Visual differences detected. 📄 Report generated: /home/runner/work/frontend/frontend/visual-diff-9086/index.html Download the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#6721
Refs ilios/ilios#6574
Refs ilios/ilios#6671
Issues fixed:
classandstyleattributes are more compact and spacing is improvedIssues not fixed (future PR)