Fixes Course Rollover future cohort display bug #9006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all are displayed when doing a rollover
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
michaelchadwick
changed the title
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jrjohnson
approved these changes
Dec 10, 2025
dartajax
approved these changes
Dec 10, 2025
Member
dartajax
left a comment
dartajax
left a comment
There was a problem hiding this comment.
I tested this from what I had originally thought was the issue - assigning a cohort to an existing course - a future cohort. This works fine now. Also the rollover cohort selection process is also fine. I approve.
michaelchadwick
deleted the
frontend-6726-fix-course-rollover-future-cohort-limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#6726
Refs ilios/ilios#4880
Due to an overfitted solution in ilios/ilios#7825, a
maxEndYearupper bound was placed on the cohort selection display. This was fine...in 2024, but in 2025 and beyond it was not.Realized there was only reason to put a lower bound to fix ilios/ilios#4880, and so removing the upper bound fixes this issue. Also added an integration test to check for this.