Use dedicated class for representing Events #8963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
event-class-v2
branch
from
da81604 to
c6b692f
Compare
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
stopfstedt
force-pushed
the
event-class-v2
branch
7 times, most recently
from
66bf647 to
1cd0607
Compare
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
stopfstedt
force-pushed
the
event-class-v2
branch
from
1cd0607 to
2dc378e
Compare
jrjohnson
reviewed
Nov 21, 2025
| * @param { Number|undefined } ilmSessionId The event's ILM session ID | ||
| * @return { String } | ||
| */ | ||
| function getSlugForUserEvent(startDate, offeringId, ilmSessionId) { |
Member
There was a problem hiding this comment.
I'm not sure why these live outside of the Event class and aren't just instance methods or getters.
Member
Author
There was a problem hiding this comment.
@jrjohnson i was waffling on this too. i could make these private methods, if that sits better with you. i wouldn't mind, as long as they don't become part of the public interface of this class.
Member
Author
There was a problem hiding this comment.
i'm gonna make these private methods. sit tight.
|
|
||
| module('Unit | Classes | Event', function (hooks) { | ||
| setupTest(hooks); | ||
| test.each( |
…put processing in constructor. all the data wrangling happens directly in the constructor now. this eliminates the need to a factory in the user/school events service. furthermore, Event.slug is now be cached getter as it should be - this required some re-shuffling of utility methods. this required a decent amount of rewiring in integration test coverage where we have to now use actual Event objects as component input instead of mock object that were hand-rolled or provided by mirage.
this is more straightforward.
stopfstedt
force-pushed
the
event-class-v2
branch
from
2dc378e to
10e7595
Compare
the Event class does a data transformation on its input in the constructor, this covers the transformed attributes.
Member
Author
|
@dartajax no functional or visual changes are to be expected here. for click-testing, please have a look at all the calendars
thanks! |
dartajax
approved these changes
Nov 21, 2025
Member
dartajax
left a comment
dartajax
left a comment
There was a problem hiding this comment.
all calendars checked - looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows us to separate derived values, such as
calendarStartYearandcalendarEndYear, from raw data points, such asstartDateandendDate, using cached getters.the sets us up for a cleaner representation going forward.
refs #8956