remove pointless data transformation.

[stopfstedt]

this doesn't do anything meaningful and gets in the way of using a more robust data structure, like a class with getters or a Proxy object. begone!

extracted from #8956

side-note

further down, we're modifying the events by setting a isMulti flag if applicable. i believe that the removed code is related to that, although i can't back that claim up based on commit messages.

ideally, we'd not be modifying these events at all, once they're generated. conceptually, they are "read only".

will explore a solution that gets rid of a event.isMulti as a separate issue.

[netlify]

✅ Deploy Preview for ilios-frontend ready!

Name	Link
🔨 Latest commit	4db5d76
🔍 Latest deploy log	https://app.netlify.com/projects/ilios-frontend/deploys/691e1a2d3f704200082c5589
😎 Deploy Preview	https://deploy-preview-8960--ilios-frontend.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[jrjohnson]

My only concern is the //clone our event, so we don't trample on the original when we change location seems to point to this doing something very specific. I don't know what though. I'm guessing it's the isMulti where we change the location to tbd? I don't have any memory for how these fit together.

[stopfstedt]

My only concern is the //clone our event, so we don't trample on the original when we change location seems to point to this doing something very specific. I don't know what though. I'm guessing it's the isMulti where we change the location to tbd? I don't have any memory for how these fit together.

this has to do with displaying multiple events as one in the weekly and monthly calendar. if it's a multi-event, clicking on it will take you to the calendar's day-view with all similar events expanded.
non-multi event will let you click through to the event's detail screen directly.

[stopfstedt]

@dartajax - for testing purposes - this change affects the dashboard calendar only.

regression testing should focus on events on the week- and month-view that expand to multiples in the day-view when clicked upon.

no functional changes are expected, this should work as before.

[dartajax]

click-tested per instructions from @stopfstedt - seems fine - no changes noticed on Dashboard calendar - clicking into multiples from Week or Month view - behaves as before so ... approval granted