-
Notifications
You must be signed in to change notification settings - Fork 27
Adds Learners column to Session->Offerings table #8949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dartajax
merged 16 commits into
ilios:master
from
michaelchadwick:frontend-3530-improve-offering-learner-visibility
Dec 3, 2025
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d758956
show learners in session->offerings tables like SessionsGrid; match u…
michaelchadwick d6f97eb
fixed multiple class spacing render issue
michaelchadwick 4cedaae
added learners to OfferingManager page-object
michaelchadwick b4d63db
added basic offering-manager integration test
michaelchadwick 0ed31ec
changed column header to be Individual Learners to reflect actual data
michaelchadwick 0ea8fb1
show all individual learners and contain in a FadeText so it truncate…
michaelchadwick eec75a1
moved learners to same column as learner groups and changed column he…
michaelchadwick 41ddb0c
fixed test to show full list of learners since we are not truncating …
michaelchadwick fd6695f
offering-manager integration test now checks for all possibilities: o…
michaelchadwick d3fc89d
changed individual learners value check to use array instead of displ…
michaelchadwick 34e197f
removed individual learner count
michaelchadwick daa739d
switch out interim locale getter value for direct primaryLocale value
michaelchadwick 8a8573a
switched to non-block version of FadeText as nothing non-default is b…
michaelchadwick e184e4b
scaled grid fr chunks up to avoid decimals
michaelchadwick 03c4a8b
removed hacky .sort() on relationship array and use proper .toSorted(…
michaelchadwick be5b1d9
check array positive length instead of mere existence
michaelchadwick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty lists are not falsy, and i'm not seeing a falsy value like null or undefined sneaking through here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed