Replace text-wrap() sass mixin with equivalent classes
#8935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
stopfstedt
previously requested changes
Nov 6, 2025
Member
stopfstedt
left a comment
stopfstedt
left a comment
There was a problem hiding this comment.
text-ellipses should be removed without replacement. we're not using it anywhere.
$ grep -r 'text-ellipses' packages --exclude-dir=dist --exclude-dir=node_modules
packages/ilios-common/app/styles/ilios-common/mixins/text-wrap.scss:@mixin text-ellipses() {
packages/ilios-common/addon/components/learningmaterial-manager.gjs
Outdated
Show resolved
Hide resolved
stopfstedt
reviewed
Nov 6, 2025
packages/ilios-common/addon/components/detail-learning-materials-item.gjs
Outdated
Show resolved
Hide resolved
stopfstedt
force-pushed
the
6623-replace-text-wrap-sass-mixin
branch
from
0a05c77 to
c90092b
Compare
stopfstedt
dismissed
their stale review
i fixed any outstanding issues and merge conflicts.
stopfstedt
approved these changes
Nov 6, 2025
michaelchadwick
force-pushed
the
6623-replace-text-wrap-sass-mixin
branch
from
51648fb to
0a05c77
Compare
stopfstedt
force-pushed
the
6623-replace-text-wrap-sass-mixin
branch
from
0a05c77 to
b58515b
Compare
…rap and text-ellipses can be used separately
stopfstedt
force-pushed
the
6623-replace-text-wrap-sass-mixin
branch
from
b58515b to
66a4fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#6623
Refs ilios/ilios#6608
This replaces the
text-wrap()SASS mixin with two new files/classes so.text-wrapand.text-ellipsescan be used separately.