Skip Todo Tests

packages/test-app/tests/integration/components/html-editor-test.gjs

@@ -1,4 +1,4 @@
-import { module, test, todo } from 'qunit';
+import { module, test, skip } from 'qunit';
 import { setupRenderingTest } from 'test-app/tests/helpers';
 import { render, triggerKeyEvent } from '@ember/test-helpers';
 import { component } from 'ilios-common/page-objects/components/html-editor';
@@ -204,7 +204,7 @@ module('Integration | Component | html editor', function (hooks) {
     assert.strictEqual(component.popup.errors[1].text, 'Link Text can not be blank');
   });
 
-  todo('it edits existing link and retains properties', async function (assert) {
+  skip('it edits existing link and retains properties', async function (assert) {
     const editor = '.html-editor';
     const tooltip = '.ql-tooltip';
     const link1 = { href: 'https://iliosproject.org', text: 'Ilios Project' };

packages/test-app/tests/integration/components/offering-form-test.gjs

@@ -1,4 +1,4 @@
-import { module, test, todo } from 'qunit';
+import { module, test, skip } from 'qunit';
 import { setupRenderingTest } from 'test-app/tests/helpers';
 import { setupMirage } from 'test-app/tests/test-support/mirage';
 import { click, render } from '@ember/test-helpers';
@@ -706,7 +706,7 @@ module('Integration | Component | offering form', function (hooks) {
     assert.strictEqual(component.url.value, 'http://example.com');
   });
 
-  todo('rejects query param with trailing slash ilios/ilios#3050', async function (assert) {
+  skip('rejects query param with trailing slash ilios/ilios#3050', async function (assert) {
     await render(<template><OfferingForm @close={{(noop)}} @showRoom={{true}} /></template>);
     assert.notOk(component.url.hasError);
     await component.url.set('http://example.com?jayden=awesome/');

packages/test-app/tests/integration/components/single-event-test.gjs

@@ -1,4 +1,4 @@
-import { module, test, todo } from 'qunit';
+import { module, test, skip } from 'qunit';
 import { setupRenderingTest } from 'test-app/tests/helpers';
 import { render } from '@ember/test-helpers';
 import Service from '@ember/service';
@@ -724,37 +724,34 @@ module('Integration | Component | ilios calendar single event', function (hooks)
     });
   });
 
-  todo(
-    "non learners don't get link to session if session route doesn't exists",
-    async function (assert) {
-      class CurrentUserMock extends Service {
-        performsNonLearnerFunction = true;
-        async getIsStudent() {
-          return true;
-        }
+  skip("non learners don't get link to session if session route doesn't exists", async function (assert) {
+    class CurrentUserMock extends Service {
+      performsNonLearnerFunction = true;
+      async getIsStudent() {
+        return true;
       }
-      this.owner.register('service:currentUser', CurrentUserMock);
+    }
+    this.owner.register('service:currentUser', CurrentUserMock);
 
-      const today = DateTime.fromObject({ hour: 8, minute: 0, second: 0 });
-      this.server.create('userevent', {
-        name: 'Learn to Learn',
-        courseTitle: 'course',
-        course: 1,
-        session: 1,
-        startDate: today.toISO(),
-        endDate: today.toISO(),
-        isBlanked: false,
-        isPublished: true,
-        isScheduled: false,
-        offering: 1,
-        lastModified: null,
-        sessionTypeTitle: 'test type',
-      });
+    const today = DateTime.fromObject({ hour: 8, minute: 0, second: 0 });
+    this.server.create('userevent', {
+      name: 'Learn to Learn',
+      courseTitle: 'course',
+      course: 1,
+      session: 1,
+      startDate: today.toISO(),
+      endDate: today.toISO(),
+      isBlanked: false,
+      isPublished: true,
+      isScheduled: false,
+      offering: 1,
+      lastModified: null,
+      sessionTypeTitle: 'test type',
+    });
 
-      this.set('event', this.server.db.userevents[0]);
-      await render(<template><SingleEvent @event={{this.event}} /></template>);
-      assert.strictEqual(component.summary.title.text, 'course - Learn to Learn');
-      assert.notOk(component.summary.title.hasLink);
-    },
-  );
+    this.set('event', this.server.db.userevents[0]);
+    await render(<template><SingleEvent @event={{this.event}} /></template>);
+    assert.strictEqual(component.summary.title.text, 'course - Learn to Learn');
+    assert.notOk(component.summary.title.hasLink);
+  });
 });

packages/test-app/tests/integration/services/current-user-test.js

@@ -1,4 +1,4 @@
-import { module, test, todo } from 'qunit';
+import { module, test, skip } from 'qunit';
 import { setupTest } from 'ember-qunit';
 import { setupMirage } from 'test-app/tests/test-support/mirage';
 import { authenticateSession, invalidateSession } from 'ember-simple-auth/test-support';
@@ -268,7 +268,7 @@ module('Integration | Service | Current User', function (hooks) {
     assert.notOk(isTeachingSession2);
   });
 
-  todo('requireNonLearner', function (/* assert */) {
+  skip('requireNonLearner', function (/* assert */) {
     // TODO: implement.
   });
 });

packages/test-app/tests/unit/utils/array-helpers-test.js

@@ -9,7 +9,7 @@ import {
   uniqueById,
   uniqueValues,
 } from 'ilios-common/utils/array-helpers';
-import { module, test, todo } from 'qunit';
+import { module, test, skip } from 'qunit';
 
 function getDogs() {
   return [
@@ -38,7 +38,7 @@ function getDogs() {
 }
 
 module('Unit | Utility | array-helpers', function () {
-  todo('when array is false', function (assert) {
+  skip('when array is false', function (assert) {
     assert.strictEqual(mapBy(false, 'name'), []);
     assert.strictEqual(sortBy(false, 'dob'), []);
     assert.strictEqual(sortBy(false, ['name', 'goodnessRanking']), []);
@@ -49,7 +49,7 @@ module('Unit | Utility | array-helpers', function () {
     assert.strictEqual(findById(false, 'jayden'), []);
     assert.strictEqual(filterBy(false, 'breed', 'Chihuahua'), []);
   });
-  todo('when array is null', function (assert) {
+  skip('when array is null', function (assert) {
     assert.strictEqual(mapBy(null, 'name'), []);
     assert.strictEqual(sortBy(null, 'name'), []);
     assert.strictEqual(sortBy(null, ['name', 'goodnessRanking']), []);
@@ -60,7 +60,7 @@ module('Unit | Utility | array-helpers', function () {
     assert.strictEqual(findById(null, 'jackson'), []);
     assert.strictEqual(filterBy(null, 'breed', 'Chihuahua'), []);
   });
-  todo('when array is undefined', function (assert) {
+  skip('when array is undefined', function (assert) {
     assert.strictEqual(mapBy(undefined, 'name'), []);
     assert.strictEqual(sortBy(undefined, 'name'), []);
     assert.strictEqual(sortBy(undefined, ['name', 'goodnessRanking']), []);