Fix report title reverting to auto-gen even after being created #8916
Conversation
…ert to '' and auto-gen the title again
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Assigned to @dartajax for testing and possible merging |
dartajax
left a comment
dartajax
left a comment
There was a problem hiding this comment.
I am not sure this is working completely. I'd recommend logging as demo_dev1 and try copying the report "All Competencies for Session Selective: Diagnosing and Managing Insomnia (2026 - 2027) in Medicine" (the first one currently).
At first I was thinking the title was too long or something. The one that currently copies the title over correctly (as far as my testing is concerned) is "All Courses in Medicine". The other ones stay blank including "All Courses in All Schools", which seems weird but there is probably a reason under the hood.
dartajax
left a comment
dartajax
left a comment
There was a problem hiding this comment.
this is better - great stuff
2 participants
Fixes ilios/ilios#6599
Fixes ilios/ilios#6600
I had more added logic in this and then realized the fix was simpler than originally expected: the
SubjectHeadercomponent just needed to take in the report title so it set its internal state variable on load. Then, if you try to change the report title but make no changes, it goes back to the report title...not ''.