-
Notifications
You must be signed in to change notification settings - Fork 27
Program->ProgramYears now keep track of expand/collapse state #8911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program->ProgramYears now keep track of expand/collapse state #8911
Conversation
… rendered template due to CSS classes
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…nstead of boolean tracking variable so expandAll works
…essions-grid-row tests; put toggle control in its own div to make testing with page-object easier
c735921 to
81a85f4
Compare
stopfstedt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| get objectiveRowClasses() { | ||
| const rowClasses = ['grid-row', 'objective-row']; | ||
|
|
||
| if (this.showRemoveConfirmation) { | ||
| rowClasses.push('confirm-removal'); | ||
| } | ||
| if (this.highlightSave.isRunning) { | ||
| rowClasses.push('highlight-ok'); | ||
| } | ||
| if (this.isManaging) { | ||
| rowClasses.push('is-managing'); | ||
| } | ||
| if (!this.args.programYearObjective.active) { | ||
| rowClasses.push('is-inactive'); | ||
| } | ||
|
|
||
| return rowClasses.join(' '); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to do it anytime I see a messy class gersplotchen in the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me
Fixes ilios/ilios#3918