Skip to content

Conversation

@michaelchadwick
Copy link
Contributor

@michaelchadwick michaelchadwick commented Oct 30, 2025

@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 81a85f4
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/69053fd965c5750008ab44e1
😎 Deploy Preview https://deploy-preview-8911--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@michaelchadwick michaelchadwick marked this pull request as ready for review October 31, 2025 22:18
…essions-grid-row tests; put toggle control in its own div to make testing with page-object easier
@michaelchadwick michaelchadwick force-pushed the frontend-3918-program-year-expand-collapse-objs branch from c735921 to 81a85f4 Compare October 31, 2025 23:01
@stopfstedt stopfstedt removed the request for review from jrjohnson November 5, 2025 22:05
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +245 to +262
get objectiveRowClasses() {
const rowClasses = ['grid-row', 'objective-row'];

if (this.showRemoveConfirmation) {
rowClasses.push('confirm-removal');
}
if (this.highlightSave.isRunning) {
rowClasses.push('highlight-ok');
}
if (this.isManaging) {
rowClasses.push('is-managing');
}
if (!this.args.programYearObjective.active) {
rowClasses.push('is-inactive');
}

return rowClasses.join(' ');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to do it anytime I see a messy class gersplotchen in the template.

@dartajax dartajax added the run ui tests Run the expensive UI tests label Nov 6, 2025
Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@dartajax dartajax merged commit 27a40af into ilios:master Nov 7, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run ui tests Run the expensive UI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide Expand All On Programs >> Program Year >> Objectives

3 participants