Eslint qunit fixes#8901
Merged
michaelchadwick merged 5 commits intoilios:masterfrom Oct 23, 2025
Merged
Conversation
please see https://github.com/qunitjs/eslint-plugin-qunit/blob/main/docs/rules/no-early-return.md for the linter error that this code was triggering.
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
…ry-term-manager-test.gjs Co-authored-by: Michael Chadwick <[email protected]>
michaelchadwick
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes all outstanding errors that are violating the recommended eslint-for-qunit rules except for
require-expect- will deal with it separately.follow-up to #3562