Skip to content

Conversation

@michaelchadwick
Copy link
Contributor

@michaelchadwick michaelchadwick commented Sep 18, 2025

Fixes ilios/ilios#4539

This report, when doing a GraphQL query of competencies never returned any results (even after giving the web server 30 minutes to finish), so something was amiss. Turns out the number of joins this has to do in the backend is too complex and never actually worked. Thus, I took the session id to find the course id to find its courseObjectives, which have programYearObjectives, which have competencies. Filter by unique values, and you get results!

@netlify
Copy link

netlify bot commented Sep 18, 2025

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 5b83ff9
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/68cc7f9338c7250008a9a58b
😎 Deploy Preview https://deploy-preview-8811--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@stopfstedt stopfstedt removed the request for review from jrjohnson September 22, 2025 17:54
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dartajax dartajax added the run ui tests Run the expensive UI tests label Sep 22, 2025
Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click tested and screen review - seems fine to me

@dartajax dartajax merged commit 3a9d0d4 into ilios:master Sep 22, 2025
39 checks passed
@michaelchadwick michaelchadwick deleted the frontend-4539-fix-comps-by-sesh-subj-report branch September 23, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run ui tests Run the expensive UI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reports - Competencies By Session Not Returning Data

3 participants