Hide Unmatched Sessions in Search #8803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we only have a course match, but the session is small enough that just the course data match scores it - displaying it is confusing for users as the badge is missing and the data isn't part of the session. Instead we can check for matchedIn and know if there was any data in the session that matched the search terms and filter out any sessions with only course data matching.
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jrjohnson
requested review from
michaelchadwick and
stopfstedt
as code owners
Otherwise we show this link where there is no more to show.
michaelchadwick
approved these changes
Sep 12, 2025
dartajax
added
run ui tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we only have a course match, but the session is small enough that just the course data match scores it - displaying it is confusing for users as the badge is missing and the data isn't part of the session. Instead we can check for matchedIn and know if there was any data in the session that matched the search terms and filter out any sessions with only course data matching.
Fixes ilios/ilios#6458