-
Notifications
You must be signed in to change notification settings - Fork 27
Lighter Bold #8777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighter Bold #8777
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dartajax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting - a lot lighter for sure but I like it - not yelling as much for sure.
|
Team Discussion - overall, good. However, in areas where user's in put data (such as session description) we should hold on to the darker bold. It is simply too light to differentiate in this content (such as in a single event view). |
Locking down on our font-weights, start with declaring that bold is now
600. Usually it is 700 by default, but we have a lot of places where
we've already set the weight at 600 so I matched that.
These are the same thing, but being more explicit helps with linting.
Standardizing on 600 for bold
Remove the option to use the confusing names and require a specific set of font weights.
Removed the font-weights we don't support
I've removed the local aliases as we're preloading these anyway so there is no gain if we pull a local copy and also modernized the src as every browser we support supports woff2 and the format syntax.
I was a little to hasty to cut these, they add nothing to our load times, but finding them again once they're gone will be annoying. Restored.
Locking in a default here, the one we've been using was 700 out of normalize.css
This is slightly less bold now which lowered the contrast against the blue background. This darker orange is more in line with our current colors anyway and meets a11y requirements.
When user input in a session description or objective title is shown to students we want it to be very bold. There is a substantial difference in appearance between 600 and 700 font weight here so I've made an exception and pushed this back to 700.
|
Bold is now bolder for student views of session description and objectives. |

I've locked in a value for our boldest font at 600. Previously we had many at 600, some defaults at 700, and some places with a mix. Hoping this will help with #8773 (review) needs review and discussion.