Fix Connection Lost Component #8775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| }); | ||
|
|
||
| reconnect = restartableTask(async (force) => { | ||
| await timeout(1); |
Contributor
There was a problem hiding this comment.
I'm not sure why this is needed, as re-rendering seems fine without it?
Member
Author
There was a problem hiding this comment.
I'm not sure if it's only in development, wasn't able to reproduce it In another way,
Steps:
pnpm start
Load ilios, disconnect network
make a change to any file that would cause a rebuild (js/gjs)
when the auto refresh happens you get an error
Contributor
There was a problem hiding this comment.
I like the new look and feel, and the only addition I would make is the "Unable to Reconnect" message < 768px. It's not vertically centered.
Member
Author
There was a problem hiding this comment.
Easy fix, good catch. ✅
jrjohnson
force-pushed
the
connection-lost
branch
from
65ea088 to
d7de949
Compare
michaelchadwick
approved these changes
Aug 19, 2025
We had a bug here that would break re-render when the network was down. This almost certainly only broke in development, but the fix is to wait a moment before doing anything. I also fixed up the style in multiple viewports so it's prettier.
jrjohnson
force-pushed
the
connection-lost
branch
from
d7de949 to
5418f00
Compare
jrjohnson
added
a11y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug here that would break re-render when the network was down. This almost certainly only broke in development, but the fix is to wait a moment before doing anything. I also fixed up the style in multiple viewports so it's prettier.
Test by loading ilios and the running off your network. You should get the banner and some other nice features.