Skip to content

Create TermsCalendarFilter component like CoursesCalendarFilter component #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stopfstedt merged 5 commits into from
Aug 18, 2025
Merged

Create TermsCalendarFilter component like CoursesCalendarFilter component #8764

stopfstedt merged 5 commits into from
Aug 18, 2025

Conversation

@michaelchadwick
Copy link
Contributor

@michaelchadwick michaelchadwick commented Aug 13, 2025

@netlify
Copy link

netlify bot commented Aug 13, 2025 •
edited
Loading

✅ Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 65c2a48
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/68a3435692a98a000805cb70
😎 Deploy Preview https://deploy-preview-8764--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 55 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 90 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@michaelchadwick michaelchadwick force-pushed the frontend-6414-add-dashboard-filter-terms-dynamic-header branch from c5ca0f5 to a0119e5 Compare August 14, 2025 22:19
@michaelchadwick michaelchadwick marked this pull request as ready for review August 14, 2025 22:19
@jrjohnson jrjohnson removed the request for review from stopfstedt August 15, 2025 17:57
jrjohnson
jrjohnson approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent change and I'm all for it as is. Once possible suggestion would be to put the <SelectedVocabulary> component in the same file as the new < TermsCalendarFilter>. I had trouble figuring out why there are two components and if one was reusable somewhere else.

@stopfstedt stopfstedt added the run ui tests Run the expensive UI tests label Aug 15, 2025
@stopfstedt stopfstedt enabled auto-merge August 15, 2025 22:45
@michaelchadwick michaelchadwick force-pushed the frontend-6414-add-dashboard-filter-terms-dynamic-header branch from a0119e5 to 65c2a48 Compare August 18, 2025 15:14
@stopfstedt stopfstedt merged commit b33e3e6 into ilios:master Aug 18, 2025
32 checks passed
@michaelchadwick michaelchadwick deleted the frontend-6414-add-dashboard-filter-terms-dynamic-header branch August 25, 2025 23:17
@jrjohnson jrjohnson added a11y PRs and issues related to making Ilios more accessi and removed run ui tests Run the expensive UI tests labels Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrjohnson jrjohnson jrjohnson approved these changes

Assignees

No one assigned

Labels

a11y PRs and issues related to making Ilios more accessi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Courses->Filters->Terms header could use a marker for where in the list you've scrolled to

3 participants

@michaelchadwick @jrjohnson @stopfstedt