Bump the ember-data group with 4 updates #8671
Conversation
dependabot
bot
added
dependencies
dependabot
bot
requested review from
jrjohnson,
michaelchadwick and
stopfstedt
as code owners
dependabot
bot
added
dependencies
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/ember-data-3a6ee9bc05
branch
2 times, most recently
from
12be110 to
fb908de
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/ember-data-3a6ee9bc05
branch
2 times, most recently
from
45ebb38 to
563df91
Compare
|
Tests are failing here as |
jrjohnson
force-pushed
the
dependabot/npm_and_yarn/ember-data-3a6ee9bc05
branch
from
667922b to
2a61232
Compare
|
jrjohnson
force-pushed
the
dependabot/npm_and_yarn/ember-data-3a6ee9bc05
branch
from
2a61232 to
f424124
Compare
|
I've rebased this and updated it to the 5.7 release of all these packages. I believe it's not ready, but would like a second set of eyes. |
|
@jrjohnson are these updates only not ready to go because of the Browserstack tests failing? Nothing else seems to fail currently. |
jrjohnson
added
run ui tests
jrjohnson
added
run ui tests
jrjohnson
force-pushed
the
dependabot/npm_and_yarn/ember-data-3a6ee9bc05
branch
from
ca626ac to
0375ec8
Compare
|
This is finally ready!! Yay!! @dartajax can you give it a thorough click through? |
|
I'd be glad to merge this but that SonarQube Code Analysis is failing. |
|
That won't block a merge. It does need a look from a dev, but I think you can start review first. @stopfstedt or @michaelchadwick can you give this a look. Most of the heavy lifting wasn't mine, but I still probably shouldn't be the reviewer. |
|
@jrjohnson I'd love to approve this, but I'm not sure how best to test a change like this. Another change that's like this, #7773, has no SonarQube Code Analysis, so no idea if it's complaining about something novel or not. |
|
Not much of a test strategy for this. It's all of our data handling so the only idea I have is to trust @dartajax's instincts to find stuff and rely on our tests. |
There was a problem hiding this comment.
Why was a percySnapshot change added to a dependency update PR?
There was a problem hiding this comment.
I got lazy, but now that I'm looking at it it should be its own PR. I'll do that now.
There was a problem hiding this comment.
Rebased and repushed with that commit on it's own.
jrjohnson
added
DO NOT MERGE
and removed
run ui tests
Bumps the ember-data group with 4 updates: [@ember-data/adapter](https://github.com/emberjs/data/tree/HEAD/packages/adapter), [@ember-data/model](https://github.com/emberjs/data/tree/HEAD/packages/model), [@ember-data/serializer](https://github.com/emberjs/data/tree/HEAD/packages/serializer) and [@warp-drive/build-config](https://github.com/emberjs/data/tree/HEAD/warp-drive-packages/build-config). Updates `@ember-data/adapter` from 5.3.12 to 5.6.0 - [Release notes](https://github.com/emberjs/data/releases) - [Changelog](https://github.com/emberjs/data/blob/v5.6.0/CHANGELOG.md) - [Commits](https://github.com/emberjs/data/commits/v5.6.0/packages/adapter) Updates `@ember-data/model` from 5.3.12 to 5.6.0 - [Release notes](https://github.com/emberjs/data/releases) - [Changelog](https://github.com/emberjs/data/blob/v5.6.0/CHANGELOG.md) - [Commits](https://github.com/emberjs/data/commits/v5.6.0/packages/model) Updates `@ember-data/serializer` from 5.3.12 to 5.6.0 - [Release notes](https://github.com/emberjs/data/releases) - [Changelog](https://github.com/emberjs/data/blob/v5.6.0/CHANGELOG.md) - [Commits](https://github.com/emberjs/data/commits/v5.6.0/packages/serializer) Updates `@warp-drive/build-config` from 5.5.0 to 5.6.0 - [Release notes](https://github.com/emberjs/data/releases) - [Changelog](https://github.com/emberjs/data/blob/v5.6.0/CHANGELOG.md) - [Commits](https://github.com/emberjs/data/commits/v5.6.0/warp-drive-packages/build-config) --- updated-dependencies: - dependency-name: "@ember-data/adapter" dependency-version: 5.6.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: ember-data - dependency-name: "@ember-data/model" dependency-version: 5.6.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: ember-data - dependency-name: "@ember-data/serializer" dependency-version: 5.6.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: ember-data - dependency-name: "@warp-drive/build-config" dependency-version: 5.6.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: ember-data ... Signed-off-by: dependabot[bot] <[email protected]>
Fixes an issue with store.query
Removing the unnecessary v prefix and allowing these packages to float to the nearest minor version.
jrjohnson
force-pushed
the
dependabot/npm_and_yarn/ember-data-3a6ee9bc05
branch
from
16128e1 to
f068e2d
Compare
jrjohnson
added
run ui tests
|
Bumps the ember-data group with 4 updates: @ember-data/adapter, @ember-data/model, @ember-data/serializer and @warp-drive/build-config.
Updates
@ember-data/adapterfrom 5.3.12 to 5.6.0Release notes
Sourced from
@ember-data/adapter's releases.Changelog
Sourced from
@ember-data/adapter's changelog.... (truncated)
Commits
03f94d2Release v5.6.01117dbaRelease v5.6.0-beta.2a22440aRelease v5.6.0-alpha.181502064Release v5.6.0-alpha.17fce8847Release v5.6.0-alpha.16261c9edchore: upgrade to vite7 (#10042)17de660chore: isolated declarations (#10040)5c9abdachore: bump pnpm (#10039)f9bdc80Release v5.6.0-alpha.15b15f121Release v5.6.0-alpha.14Updates
@ember-data/modelfrom 5.3.12 to 5.6.0Release notes
Sourced from
@ember-data/model's releases.Changelog
Sourced from
@ember-data/model's changelog.... (truncated)
Commits
03f94d2Release v5.6.01117dbaRelease v5.6.0-beta.2a22440aRelease v5.6.0-alpha.181502064Release v5.6.0-alpha.17fce8847Release v5.6.0-alpha.16261c9edchore: upgrade to vite7 (#10042)17de660chore: isolated declarations (#10040)5c9abdachore: bump pnpm (#10039)f9bdc80Release v5.6.0-alpha.15b15f121Release v5.6.0-alpha.14Updates
@ember-data/serializerfrom 5.3.12 to 5.6.0Release notes
Sourced from
@ember-data/serializer's releases.Changelog
Sourced from
@ember-data/serializer's changelog.... (truncated)
Commits
03f94d2Release v5.6.01117dbaRelease v5.6.0-beta.2a22440aRelease v5.6.0-alpha.181502064Release v5.6.0-alpha.17fce8847Release v5.6.0-alpha.16261c9edchore: upgrade to vite7 (#10042)17de660chore: isolated declarations (#10040)5c9abdachore: bump pnpm (#10039)f9bdc80Release v5.6.0-alpha.15b15f121Release v5.6.0-alpha.14Updates
@warp-drive/build-configfrom 5.5.0 to 5.6.0Release notes
Sourced from
@warp-drive/build-config's releases.Changelog
Sourced from
@warp-drive/build-config's changelog.... (truncated)
Commits
03f94d2Release v5.6.01117dbaRelease v5.6.0-beta.2a22440aRelease v5.6.0-alpha.181502064Release v5.6.0-alpha.17fce8847Release v5.6.0-alpha.168f99616fix small thing261c9edchore: upgrade to vite7 (#10042)17de660chore: isolated declarations (#10040)5c9abdachore: bump pnpm (#10039)f9bdc80Release v5.6.0-alpha.15You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions