Skip to content

Conversation

@jrjohnson
Copy link
Member

Functioning Instructor group management.
@saschaben please review behavior at: https://frontend-c9-jrjohnson.c9.io/

@thecoolestguy
Copy link
Member

From what I can tell, this looks good syntactically... @jrjohnson, do you want the behavior tested before merge?

@jrjohnson
Copy link
Member Author

Yes. For all of our frontend changed @saschaben will be the final arbiter of good behavior.

@saschaben
Copy link
Member

functional behavior appears OK. we're getting some wonky caching in the group name textarea, but assuming that is UI related.

@jrjohnson jrjohnson changed the title Basic Instructor Groups (WIP) Basic Instructor Groups Oct 16, 2014
@jrjohnson
Copy link
Member Author

Hopefully fixed the caching bug @saschaben picked up. Updated the link with new code to test.

@saschaben
Copy link
Member

@jrjohnson previous borkage appears fixed. However, now there is new borkage with the "New Instructor Group" feature. Click button, opens inline text entry field, attempt to add title value, the list tries to auto-sort by alpha as you enter, along with challenged deletion etc. please revisit. We may want to use the "open the new edit page" pattern here....

When a new group is added use an alias property so the title doesn't sort until it is saved.
Also added a flat remove button because there is no loss if a new group is removed since it contains no data.
@jrjohnson
Copy link
Member Author

I fixed the sorting list problem with new groups. I don't know why I never noticed that in development, i'm guessing I was entering xxxtest or something every time. Anyway, fixed that. I also changed the display for new items to either save or delete. I made the delete happen with no confirmation because there is no risk of data loss since the only thing added at this point is a title.

New code at the same link.

@saschaben
Copy link
Member

OK. all seems far mo' bettah now. I'd give this a functional pass at this point.

one thing that will likely come up in other areas as well: when you add a new group and save, and it "jumps" into its place in the sort, it's so immediate as to be a little jarring. Is there a function/method/script/hack/widget we can use or steal to create a fractional delay/animation for transitions like these where the visual shift is significant, but the time of the shift is infinitesimal? I know this isn't a major deal, but if we start looking now at ways to smooth out the experience.....anyway, just something to ponder and/or keep an eye out for.

@saschaben saschaben closed this Oct 17, 2014
@saschaben saschaben reopened this Oct 17, 2014
@jrjohnson
Copy link
Member Author

Yes, transitions and loading need to be smoothed out. Also GIANTS WIN THE PENNANT!GIANTS WIN THE PENNANT!GIANTS WIN THE PENNANT!

dartajax added a commit that referenced this pull request Oct 17, 2014
@dartajax dartajax merged commit 4a40b5e into ilios:master Oct 17, 2014
@jrjohnson jrjohnson deleted the instructorgroups branch October 17, 2014 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants