Fix assistant prefill in OAI chat API#874
Merged
ikawrakow merged 1 commit intoikawrakow:mainfrom Oct 29, 2025
Merged
Conversation
Collaborator
|
Thanks for this PR. It was indeed what I missed. I will test it when I'm home. |
Collaborator
|
LGTM |
firecoperana
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for prefilling assistant messages in the v1/chat/completions endpoint was added in #723 (directly ported over from mainline), but until now it has not been functional. I had a look and realised the author missed a few lines from the source implementation, responsible for actually appending the prefilled content to the chat. This change simply restores them.