Conversation
ikawrakow
reviewed
Sep 23, 2025
| float yarn_attn_factor = 1.0f; // YaRN magnitude scaling factor | ||
| float yarn_beta_fast = 32.0f; // YaRN low correction dim | ||
| float yarn_beta_slow = 1.0f; // YaRN high correction dim | ||
| float yarn_attn_factor = -1.0f; // YaRN magnitude scaling factor |
Collaborator
Author
There was a problem hiding this comment.
This copies from mainline.
ikawrakow
approved these changes
Sep 23, 2025
src/llama-vocab.h
Outdated
| LLAMA_VOCAB_PRE_TYPE_HUNYUAN = 36, | ||
| LLAMA_VOCAB_PRE_TYPE_KIMI_K2 = 37, | ||
| LLAMA_VOCAB_PRE_TYPE_HUNYUAN_DENSE = 38, | ||
| LLAMA_VOCAB_PRE_TYPE_GROK_2 = 39, |
Owner
There was a problem hiding this comment.
Align '=' as the other entries
firecoperana
force-pushed
the
fcp/grok2
branch
from
d16e7ef to
5755a99
Compare
firecoperana
force-pushed
the
fcp/grok2
branch
from
5755a99 to
1b0e32a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for grok-2.
Test with unsloth/grok-2-UD-Q2_K_XL.gguf and looks ok.
Use
--jinjafor loading the model withllama-serverggml-org/llama.cpp#15539