Revert "Better CPU prompt processing performance for SWA models (#696)"#701
Merged
Revert "Better CPU prompt processing performance for SWA models (#696)"#701
Conversation
This reverts commit 93a4f60.
|
Me too. Was just in the process of recompiling with the commit removed to see if that's it. GLM-4.5 gave segfault. |
Contributor
|
here as well, was just about to report |
|
pure cpu also crash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearly I did not test well enough. The PR leads to a segmentation fault with hybrid GPU/CPU inference.