Fix KV cache for split mode graph with layers left on CPU#1506
Merged
Fix KV cache for split mode graph with layers left on CPU#1506
Conversation
|
Unable to run smol-IQ2_KS GLM5 full gpu offload after this pull. |
ikawrakow
added a commit
that referenced
this pull request
Mar 26, 2026
ikawrakow
added a commit
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using split mode
graphand attention tensors in some layers are left on the CPU, on the main branch the KV cache for these layers is left uninitialized, which leads to a crash during compute graph construction. The PR fixes the bug.I had never run a dense model with split mode
graphand not all layers offloaded to the GPU. Came across this bug while testing the auto-fit functionality from #1504 with a dense model that does not fit in VRAM.