Conversation
Owner
Author
|
OK, I added This is, somewhat disappointingly, only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR further optimizes
adaptive_psampling compared to PR #1161. For more context, see the discussion there.To actually measure the time spent in the
adaptive_psampler, one needs to add up the time spent in all of its functions, not just the final sampling time, which is fast. This is done in this PR and also in #1161, but I also modified the main branch (not pushed here) to be able to compare.Here the results of a quick experiment with Qwne3-30B-A3B-Q8_0,
adaptive_penabled, prompt "Give me an extended summary of the history of Bulgaria". We see a massive improvement between the main branch and #1161 (~17X), and an additional speedup of 2.4X in this PR.Main branch
PR #1161
This PR