Skip to content

feat(cosmosfaucet): loosen faucet check when indexer disabled#4633

Merged
julienrbrt merged 5 commits intomainfrom
julien/disable-indexer
Apr 18, 2025
Merged

feat(cosmosfaucet): loosen faucet check when indexer disabled#4633
julienrbrt merged 5 commits intomainfrom
julien/disable-indexer

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Apr 17, 2025 •
edited
Loading

Closes: #4528

Ignite CLI will now check the user config.yml for an indexer override and skip the checks accordignly:

validators:
  - name: alice
    bonded: 100000000stake
    config:
      tx_index:
        indexer: "null"

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Apr 17, 2025
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. component:packages labels Apr 17, 2025
laciferin2024
laciferin2024 approved these changes Apr 17, 2025
View reviewed changes
Copy link

@laciferin2024 laciferin2024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome bugfix

@julienrbrt julienrbrt merged commit 8e76c5f into main Apr 18, 2025
42 of 43 checks passed
@julienrbrt julienrbrt deleted the julien/disable-indexer branch April 18, 2025 05:47
mergify bot pushed a commit that referenced this pull request Apr 18, 2025
@julienrbrt @mergify
feat(cosmosfaucet): loosen faucet check when indexer disabled (#4633)
13bea6f 
(cherry picked from commit 8e76c5f)

# Conflicts:
#	ignite/services/chain/faucet.go
julienrbrt added a commit that referenced this pull request Apr 18, 2025
@mergify @julienrbrt
feat(cosmosfaucet): loosen faucet check when indexer disabled (backport
a1419ce 
#4633) (#4637)

* feat(cosmosfaucet): loosen faucet check when indexer disabled (#4633)

(cherry picked from commit 8e76c5f)

# Conflicts:
#	ignite/services/chain/faucet.go

* fix conflicts

* fix

* fix import

---------

Co-authored-by: julienrbrt <julien@rbrt.fr>
@BrewTestBot BrewTestBot mentioned this pull request Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@salmad3 salmad3 Awaiting requested review from salmad3

@toschdev toschdev Awaiting requested review from toschdev

+1 more reviewer

@laciferin2024 laciferin2024 laciferin2024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@julienrbrt julienrbrt

Labels

backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs component:packages type:services Service-related issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FIX: faucet stops working with psql indexer

3 participants

@julienrbrt @Pantani @laciferin2024