Merged
Conversation
julienrbrt
requested review from
Pantani,
ilgooz and
jeronimoalbi
as code owners
github-actions
bot
added
component:ci
Member
Author
|
Super weird, looks like the library used by json library <cosmossdk.io/log doesn't support Go 1.24 yet. |
Member
Author
|
We can go further after bytedance/sonic#741 |
julienrbrt
force-pushed
the
julien/124
branch
from
611994c to
604fcfb
Compare
julienrbrt
added a commit
that referenced
this pull request
Feb 17, 2025
julienrbrt
added a commit
that referenced
this pull request
Feb 17, 2025
* feat(services): add faucet fee config * cl * pin 1.23 to ci (ref #4509) * fix
julienrbrt
added a commit
that referenced
this pull request
Feb 17, 2025
* feat(services): add faucet fee config (#4513) * feat(services): add faucet fee config * cl * pin 1.23 to ci (ref #4509) * fix (cherry picked from commit 4abea76) # Conflicts: # ignite/config/chain/base/config.go * conflict --------- Co-authored-by: Julien Robert <[email protected]>
This was referenced Feb 18, 2025
Member
Author
|
@Pantani should be good to review again |
Pantani
approved these changes
Mar 8, 2025
Collaborator
Pantani
left a comment
Pantani
left a comment
There was a problem hiding this comment.
LGMT
ACK, tested with a new chain and a chain scaffolded with a preview Golang version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump cli + app to Go 1.24 and use the new tool pattern: https://go.dev/doc/modules/managing-dependencies#tools