Merged
Conversation
julienrbrt
added
skip-changelog
julienrbrt
requested review from
Pantani,
ilgooz and
jeronimoalbi
as code owners
github-actions
bot
added
component:ci
salmad3
approved these changes
Jan 16, 2025
Contributor
salmad3
left a comment
salmad3
left a comment
There was a problem hiding this comment.
An enhancement could be to unify the JSON serialization into a single shared function (e.g., SaveAsJSON) and call it from each struct’s method
Member
Author
I don't really get the advantage. For connect for instance we just need the struct, and in CLI calling them separately is fine right |
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
* feat: expose chain-registry structs * updates * split * structure * updates * lint (cherry picked from commit ec26e2e) # Conflicts: # ignite/services/scaffolder/chain_registry.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the chain registry structs that were recently added.
This package will then be used by Ignite Connect app to avoid duplication (ignite/apps#102)