Merged
Conversation
github-actions
bot
added
component:ci
julienrbrt
requested review from
ilgooz,
jeronimoalbi,
salmad3 and
toschdev
as code owners
julienrbrt
requested review from
Pantani,
jeronimoalbi,
salmad3 and
toschdev
as code owners
Member
Author
|
Follow-up will be to create an integration tests, and then update the ignite/web frontend (see #4414). |
github-actions
bot
added
the
component:docs
Contributor
|
Visit the preview URL for this PR (updated for commit fd14adf): https://igntservices-docs--pr4347-julien-ts-client-kulg16we.web.app (expires Thu, 24 Apr 2025 14:37:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5 |
Pantani
reviewed
Apr 17, 2025
Pantani
approved these changes
Apr 17, 2025
Collaborator
Pantani
left a comment
Pantani
left a comment
There was a problem hiding this comment.
the generation looks good but I didn't tested the ts files
Collaborator
|
LGMT!!! |
Member
Author
Yep! Hard to test without updating the client, this is the next step. I compared against v27 and it looked the same. |
mergify bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
* fix(cosmosgen): fix ts-client * cl * fix path * add axios + fix typescript path * simplify * updates * rm consensus chain specific logic * fix * fix templates * fix type discovery * lint * remove broken disclaimer from docs * add error goup at correct place * lint (cherry picked from commit 1fc0b9a) # Conflicts: # ignite/cmd/generate_typescript_client.go # ignite/pkg/cosmosgen/generate_typescript.go # ignite/pkg/cosmosgen/template.go
julienrbrt
added a commit
that referenced
this pull request
Apr 17, 2025
* fix(cosmosgen): fix ts-client (#4347) * fix(cosmosgen): fix ts-client * cl * fix path * add axios + fix typescript path * simplify * updates * rm consensus chain specific logic * fix * fix templates * fix type discovery * lint * remove broken disclaimer from docs * add error goup at correct place * lint (cherry picked from commit 1fc0b9a) # Conflicts: # ignite/cmd/generate_typescript_client.go # ignite/pkg/cosmosgen/generate_typescript.go # ignite/pkg/cosmosgen/template.go * updates --------- Co-authored-by: julienrbrt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4305
ref: #4414