feat(pkg): improve xgenny dry run (backport #4001)#4234
Closed
mergify[bot] wants to merge 8 commits intorelease/v28.x.yfrom
Closed
feat(pkg): improve xgenny dry run (backport #4001)#4234mergify[bot] wants to merge 8 commits intorelease/v28.x.yfrom
mergify[bot] wants to merge 8 commits intorelease/v28.x.yfrom
Conversation
* run all dry runners before the we runners for the xgenny pkg * add changelog * Improve `xgenny` dry run * replace the last wet runners * create RunAndApply runner function * remove unused parameters from scaffold functions and fix wrong path for scaffold chain * run go mod tidy before go fmt * bump buf build * fix golden files for apps tests * create the runner target path if not exist * update go.mod * fix lint issue * fix doctor absolute path * re-organize xgenny pkg * fix lint warning --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 2ad41ee) # Conflicts: # ignite/cmd/chain.go # ignite/cmd/scaffold.go # ignite/cmd/scaffold_chain.go # ignite/cmd/scaffold_configs.go # ignite/cmd/scaffold_message.go # ignite/cmd/scaffold_module.go # ignite/cmd/scaffold_packet.go # ignite/cmd/scaffold_params.go # ignite/cmd/scaffold_query.go # ignite/pkg/xgenny/run.go # ignite/services/chain/init.go # ignite/services/chain/proto.go # ignite/services/doctor/doctor.go # ignite/services/scaffolder/configs.go # ignite/services/scaffolder/init.go # ignite/services/scaffolder/message.go # ignite/services/scaffolder/module.go # ignite/services/scaffolder/packet.go # ignite/services/scaffolder/params.go # ignite/services/scaffolder/query.go # ignite/services/scaffolder/scaffolder.go # ignite/services/scaffolder/type.go
Contributor
Author
|
Cherry-pick of 2ad41ee has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pantani
approved these changes
Jul 2, 2024
Contributor
|
Visit the preview URL for this PR (updated for commit c312a37): https://igntservices-docs--pr4234-mergify-bp-release-v-00v5xbcs.web.app (expires Thu, 11 Jul 2024 14:22:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5 |
* chore: bump buf build (#4002) * bump buf build * fix golden files for apps tests * add changelog --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 5c9966d) # Conflicts: # go.mod # go.sum * fix merge conflicts * fix changelog --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2565
Description
Improve the
xgennypackage by creating a custom runner to salve all modifications into a temporary folder and only apply and copy all files to the target directory later.Changes
This PR removes the default dry and wet runners, avoiding running two generators. If everything works fine, only one will run into a temporary folder and be copied to the target folder.
This is an automatic backport of pull request #4001 done by Mergify.