chore: enable errcheck linter#4162
Merged
julienrbrt merged 18 commits intoignite:mainfrom Jun 18, 2024
Merged
Conversation
faddat
requested review from
Pantani,
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
github-actions
bot
added
component:ci
Contributor
Author
|
this will show the bug surfaced in #4156 |
Merged
Contributor
Author
|
I'll resolve conflicts later today |
Collaborator
|
the cleanup method from the |
Pantani
previously approved these changes
Jun 13, 2024
# Conflicts: # ignite/internal/plugin/testdata/execute_fail/go.mod # ignite/internal/plugin/testdata/execute_ok/go.mod
Pantani
approved these changes
Jun 13, 2024
julienrbrt
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in how flag tests are handled. Since we're now checking if the test runs return error, we are able to see that flag tests have been failing because they don't include a value.
Link to earlier issue
I think that this PR shows the same behavior showed in #4074. Specifically, It set off the race detector. I don't think that is because of the linting changes. The difference between:
and
is intentionally just a single comment.
Running tests on ubuntu fails in the first commit, but passes in the second. So, what I'm suggesting here is that we should make a PR that runs the tests 10x against the current main branch. This will let us observe the tests and know if they are flaky.
But it doesn't seem to be related to the
errcheckwork. Here's the data race here:That's from
main. I think we should spend some additional time looking for data races.Please make sure to check the following for your PR:
Ignite CLI team only:
ignite/templates/fileshave been changed, makesure that the change doesn't need to be reflected in the
ignite/templates/files-*folders.