chore: enable copyloopvar linter

.golangci.yml

@@ -5,6 +5,7 @@ linters:
   disable-all: true
   enable:
     - bodyclose
+    - copyloopvar
     - decorder
     - depguard
     - dogsled
@@ -70,7 +71,5 @@ linters-settings:
 issues:
   exclude-dirs:
     - ignite/ui
-  #   # timeout for analysis, e.g. 30s, 5m, default is 1m
-  #   timeout: 5m
   max-issues-per-linter: 0
   max-same-issues: 0

changelog.md

@@ -23,6 +23,7 @@
 
 ### Changes
 
+- [#4160](https://github.com/ignite/cli/pull/4160) Enable copyloopvar linter
 - [#4159](https://github.com/ignite/cli/pull/4159) Enable gci linter
 - [#4157](https://github.com/ignite/cli/pull/4157) Upgrade golang to 1.22
 - [#4094](https://github.com/ignite/cli/pull/4094) Scaffolding a multi-index map using `ignite s map foo bar baz --index foobar,foobaz` is no longer supported. Use one index instead of use `collections.IndexedMap`.

go.mod

@@ -2,7 +2,7 @@ module github.com/ignite/cli/v29
 
 go 1.22
 
-toolchain go1.22.2
+toolchain go1.22.3
 
 replace (
 	github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0

ignite/cmd/chain.go

@@ -288,7 +288,7 @@ func configMigrationPreRunHandler(cmd *cobra.Command, session *cliui.Session, ap
 			return err
 		}
 
-		if err := os.WriteFile(cfgPath, buf.Bytes(), 0o755); err != nil {
+		if err := os.WriteFile(cfgPath, buf.Bytes(), 0o600); err != nil {
 			return errors.Errorf("config file migration failed: %w", err)
 		}
 	}

ignite/cmd/plugin_test.go

@@ -86,7 +86,7 @@ func TestLinkPluginCmds(t *testing.T) {
 	)
 
 	// helper to assert pluginInterface.Execute() calls
-	expectExecute := func(t *testing.T, ctx context.Context, p *mocks.PluginInterface, cmd *plugin.Command) {
+	expectExecute := func(t *testing.T, _ context.Context, p *mocks.PluginInterface, cmd *plugin.Command) {
 		t.Helper()
 		p.EXPECT().
 			Execute(

ignite/pkg/cmdrunner/cmdrunner.go

@@ -107,7 +107,6 @@ func (r *Runner) Run(ctx context.Context, steps ...*step.Step) error {
 				step.Exec.Command,
 				strings.Join(step.Exec.Args, " "))
 		}
-		step := step
 		if err := ctx.Err(); err != nil {
 			return err
 		}

ignite/pkg/cosmosgen/generate_composables.go

@@ -118,8 +118,6 @@ func (g *composablesGenerator) generateComposableTemplates(p generatePayload) er
 	gg := &errgroup.Group{}
 
 	for _, m := range p.Modules {
-		m := m
-
 		gg.Go(func() error {
 			return g.generateComposableTemplate(m, p)
 		})

ignite/pkg/cosmosgen/generate_typescript.go

@@ -81,8 +81,6 @@ func (g *tsGenerator) generateModuleTemplates(ctx context.Context) error {
 	dirCache := cache.New[[]byte](g.g.cacheStorage, dirchangeCacheNamespace)
 	add := func(sourcePath string, modules []module.Module) {
 		for _, m := range modules {
-			m := m
-
 			gg.Go(func() error {
 				cacheKey := m.Pkg.Path
 				paths := []string{m.Pkg.Path, g.g.opts.jsOut(m)}

ignite/services/chain/init.go

@@ -229,10 +229,6 @@ func (c *Chain) IsInitialized() (bool, error) {
 	if _, err := os.Stat(gentxDir); os.IsNotExist(err) {
 		return false, nil
 	}
-	if err != nil {
-		// Return error on other error
-		return false, err
-	}
 
 	return true, nil
 }

ignite/version/version_test.go

@@ -44,7 +44,6 @@ func TestAssertSupportedCosmosSDKVersion(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			err := version.AssertSupportedCosmosSDKVersion(tc.version)
 			if tc.errMsg == "" {