refactor(templates)!: remove ValidateBasic() and use address codec#4058
Merged
julienrbrt merged 9 commits intomainfrom Apr 2, 2024
Merged
refactor(templates)!: remove ValidateBasic() and use address codec#4058julienrbrt merged 9 commits intomainfrom
julienrbrt merged 9 commits intomainfrom
Conversation
github-actions
bot
added
component:ci
julienrbrt
force-pushed
the
julien/del-validate-basic-codec
branch
from
347231b to
ae8a46e
Compare
julienrbrt
force-pushed
the
julien/del-validate-basic-codec
branch
from
ae8a46e to
e592423
Compare
julienrbrt
commented
Mar 28, 2024
ignite/templates/ibc/files/packet/component/x/{{moduleName}}/keeper/{{packetName}}.go.plush
Show resolved
Hide resolved
julienrbrt
requested review from
Pantani,
ilgooz,
jeronimoalbi,
salmad3 and
toschdev
as code owners
Pantani
reviewed
Apr 1, 2024
.../templates/typed/map/files/messages/x/{{moduleName}}/keeper/msg_server_{{typeName}}.go.plush
Outdated
Show resolved
Hide resolved
.../templates/typed/map/files/messages/x/{{moduleName}}/keeper/msg_server_{{typeName}}.go.plush
Outdated
Show resolved
Hide resolved
...typed/map/files/tests/messages/x/{{moduleName}}/keeper/msg_server_{{typeName}}_test.go.plush
Show resolved
Hide resolved
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4058 +/- ##
=======================================
Coverage 26.09% 26.09%
=======================================
Files 304 304
Lines 25594 25594
=======================================
+ Hits 6678 6680 +2
+ Misses 18327 18326 -1
+ Partials 589 588 -1 |
Pantani
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove ValidateBasic() from scaffolded modules.
Use address codec instead of
AccAddressFromBech32Closes: #4042