feat: remove all import placeholders using the xast pkg#4004
Merged
Conversation
github-actions
bot
added
component:ci
Pantani
changed the title
xast pkg
Pantani
requested review from
ilgooz,
jeronimoalbi,
julienrbrt,
salmad3 and
toschdev
as code owners
jeronimoalbi
approved these changes
Mar 8, 2024
julienrbrt
approved these changes
Mar 8, 2024
Member
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
tACK.
love the imports' replacement, but a bit less the magic look of the keeper addition.
mergify bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
* remove all import placeholders * add changelog * remove unused placeholders * fix wrong import path * improve readbility * remove keeper definition placeholder --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 59400a5) # Conflicts: # ignite/templates/ibc/placeholders.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.plushimports and add them using thexast.AppendImportsfunction;app.go.plushand add them using thexast.ModifyFunctionfunction;