Merged
Conversation
julienrbrt
requested review from
Pantani,
ilgooz,
jeronimoalbi,
salmad3 and
toschdev
as code owners
github-actions
bot
added
component:ci
jeronimoalbi
approved these changes
Mar 1, 2024
Pantani
approved these changes
Mar 1, 2024
Collaborator
I totally agree, it makes more sense to have an Oracle app. Sad because this was my first task working in the cosmos ecosystem 😁😅 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3993 +/- ##
==========================================
+ Coverage 25.70% 26.14% +0.44%
==========================================
Files 307 304 -3
Lines 25730 25302 -428
==========================================
+ Hits 6614 6616 +2
+ Misses 18539 18110 -429
+ Partials 577 576 -1
|
This was referenced Mar 1, 2024
julienrbrt
added a commit
that referenced
this pull request
Mar 6, 2024
* refactor!: remove oracle support * changelog --------- Co-authored-by: Danilo Pantani <[email protected]>
julienrbrt
added a commit
that referenced
this pull request
May 29, 2024
* refactor!: remove oracle support * changelog --------- Co-authored-by: Danilo Pantani <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
* refactor!: remove oracle support * changelog --------- Co-authored-by: Danilo Pantani <[email protected]> (cherry picked from commit 496daaf) # Conflicts: # ignite/cmd/scaffold_band.go # ignite/services/scaffolder/oracle.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of maintaining oracle support, I propose, as it is deprecated, we simply drop it: #3727.
There is a wide choice of oracle that people can integrate with, and we should, if we want to continue support, after #3933 make it an app per oracle service.
This avoids maintaining those plush files as well to keep them compatible with the latest ignite and sdk development.
closes: #3727