feat: add scaffold configs and scaffold params commands and start remove placeholders#3770
Merged
feat: add scaffold configs and scaffold params commands and start remove placeholders#3770
scaffold configs and scaffold params commands and start remove placeholders#3770Conversation
Pantani
changed the title
scaffold param commandscaffold params command
Pantani
requested review from
Ehsan-saradar,
ilgooz,
jeronimoalbi,
julienrbrt,
salmad3 and
toschdev
as code owners
julienrbrt
reviewed
Nov 24, 2023
Member
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
Given the current and the fact this command is additive, doing a ignite s module bar will still scaffold params. How are you supposed to use this command?
Collaborator
Author
We can create a chain with a default module and add the parameters later: ignite s chain github.com/Pantani/mars && cd mars
ignite scaffold params foo bar:uint baz:bool -yOr we can also create a module with params and add more parameters later: ignite s chain github.com/Pantani/mars && cd mars
ignite scaffold module foo --params foo:uint,bar:bool -y
ignite scaffold params baz boo:uint bla:bool --module foo -yLet's create something in the docs about it. wdyt @toschdev ? |
added 14 commits
February 19, 2024 10:05
# Conflicts: # ignite/cmd/scaffold_chain.go
Pantani
changed the title
scaffold configs and scaffold params commandsscaffold configs and scaffold params commands and start remove placeholders
julienrbrt
approved these changes
Feb 22, 2024
julienrbrt
added a commit
that referenced
this pull request
May 3, 2024
* feat: backport xast package to v28 Co-authored-by: Danilo Pantani <[email protected]>
Merged
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
… remove placeholders (#3770) * add parameters placeholders and modifier * add scaffold params command * add changelog * check if the parameter already exist * add integration tests and fix some import issues * improve the scaffolder logic * improve the log message * fix the log message * fix changelog * fix 28 imports * remove params module * add module configs command * rollbak empty line for proto * improve code readbility and add unit tests * fix changelog * use cli error package * Update ignite/cmd/scaffold_configs.go Co-authored-by: Jerónimo Albi <[email protected]> * apply pr suggestions * fix some typos * remove unused vars and casting * add replacer pkg for goanalysis * add TODO comment * add modify call function * test readbility * improve organization * fix the function modifier logic * fix the arg idente for caller replace * add more test cases and last fixes * start replace the params template to the xast * add append struct param option * add support to add new struct params * fix some lint issues * add small fixes and improve code readbility * fix append code parser * fix changelog --------- Co-authored-by: Pantani <Pantani> Co-authored-by: Jerónimo Albi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3684
Description
Configs
We can create a chain with a default module and add the configs later:
Or we can also create a module with params and add more configs later:
Params
We can create a chain with a default module and add the parameters later:
Or we can also create a module with params and add more parameters later:
This PR also introduces a new way to add code without placeholders!!!