Fix memory leak

[hectorj]

Hi!

First, thank you for your work on clammit.

There is a small memory leak which starts to show when handling lots of requests. I found a corresponding issue in the go-clamd library used: dutchcoders/go-clamd#9

Here is a small patch to fix it. I tried it and it did stabilize memory usage.

[vjt]

LGTM, thank you.

@jblackman cleared for merge?

May the 4th be with you! :-)

[hectorj]

To be complete, here is the pprof heap flamegraph I get after a large amount of requests (before this PR):

[jblackman]

The loop to suck the chan dry seems a bit hacky to me. It would be better to address this in go-clamd itself, IMO, but if you are pressed for time, then all good.

[hectorj]

The loop to suck the chan dry seems a bit hacky to me. It would be better to address this in go-clamd itself, IMO, but if you are pressed for time, then all good.

Agreed, it is a quickfix (I'm worried go-clamd is not maintained anymore, though I can still try a PR)

[Helios-23]

When is this memory leak fix going to be rolled into the main/release?

[vjt]

When is this memory leak fix going to be rolled into the main/release?

Hello,

I prefer to fix this in go-clamd, please hold until the end of this week, I'll update this issue by then.

[vjt]

Dear @hectorj thanks for your contribution. As I wasn't able to focus on this, I've merged your fix and released v0.7.3. I anyway leave #27 open to proper fix this in go-clamd.

Cheers