Dropdown Select by Language #9
Conversation
idosal
left a comment
idosal
left a comment
There was a problem hiding this comment.
Thanks for the PR! Added a few comments. It looks like there are missing commits.
Please attach a screenshot of the resulting UI.
| voices.sort((a, b) => a.lang.localeCompare(b.lang)); | ||
|
|
||
| // Limit number of voices shown to 250 | ||
| voices = voices.slice(0, 250); |
| }; | ||
|
|
||
| const handleLanguageChange = (event) => { | ||
| setSelectedLanguage(event.target.value); |
There was a problem hiding this comment.
This method doesn't exist in this PR.
| ))} | ||
| </select> | ||
| <select value={ selectedVoice } onChange={handleVoiceChange}> | ||
| {voices.map((voice) => ( |
There was a problem hiding this comment.
Shouldn't this list be filtered by the chosen language? We should filter a new list on change and display that.
| {voice.name} ({voice.lang}) | ||
| </option> | ||
| ))} | ||
| <select value={ selectedLanguage } onChange={handleLanguageChange}> |
There was a problem hiding this comment.
Please reformat the code using Prettier.
|
Sorry I did a mistake, by making the pull while I am still setting up the environnement for Node (I am not familiar with how it works), while I am also trying to have ChatGPT "help"... The idea is to make a separate dropdown list for languages so it becomes easier to select... I am still trying to figure out a lot of things including how to test locally and debug, I thought that I am doing the PR on my fork... Thank you for taking time to comment, I will try to be more careful (I did but still failed) |
|
No worries, it's all good. :) |
2 participants
No description provided.