-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update actions in solid_mechanics #32428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WilkAndy
wants to merge
5
commits into
idaholab:next
Choose a base branch
from
WilkAndy:update_actions_32410
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
feb042a
Change action to QuasiStatic. Refs #32410
WilkAndy 6517213
Change action to Dynamic. Refs #32410
WilkAndy 62ed320
Remove 'not-recommended' syntax option from documentation as inputs w…
GiudGiud 4d830b8
Remove example for syntax that requires pairing with a deprecated syntax
GiudGiud c93ac06
Address review comments:
GiudGiud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,15 +31,13 @@ The `GeneralizedPlaneStrain` Action is used to construct the kernels, user objec | |
| ### Subblocks | ||
|
|
||
| The subblocks of the GeneralizedPlaneStrain action are what triggers MOOSE objects to be built. | ||
| If a generalized plane strain model is applied for the whole simulation domain, a single subblock should be used | ||
|
|
||
| !listing modules/solid_mechanics/test/tests/generalized_plane_strain/out_of_plane_pressure.i block=Physics/SolidMechanics/GeneralizedPlaneStrain | ||
|
|
||
| if different mesh subdomain has different generalized plane strain model, multiple subblocks with subdomain restrictions can be used. | ||
| If a generalized plane strain model is applied for the whole simulation domain, a single subblock should be used. | ||
| If different mesh subdomain has different generalized plane strain model, multiple subblocks with subdomain restrictions can be used. | ||
| This syntax is paired with the `[Kernels/SolidMechanics]` syntax which is deprecated. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as my comment on this in another file.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is the same action, just different syntax |
||
|
|
||
| !listing modules/solid_mechanics/test/tests/generalized_plane_strain/generalized_plane_strain_squares.i block=Physics/SolidMechanics/GeneralizedPlaneStrain | ||
|
|
||
| An example of using generalized plane strain action through the Solid Mechanics quasi-static physics block with a different `out_of_plane_direction` than the default of $z$ is given by: | ||
| The non-deprecated syntax is to use the generalized plane strain action through the Solid Mechanics quasi-static physics block with a different `out_of_plane_direction` than the default of $z$ is given by: | ||
|
|
||
| !listing modules/solid_mechanics/test/tests/2D_different_planes/gps_xz.i block=Physics/SolidMechanics/QuasiStatic/generalized_plane_strain | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is there no way to do this with non-deprecated syntax? That is an important feature, so we should properly support that if we can't. Can't we do this with multiple blocks with generalized plane strain nested under
[Physics/SolidMechanics/QuasiStatic]?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont think but feel free to try it
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried
do you see an error in that? This does not converge (in generalized_plain_strain_squares.i)
I think the other action syntax (all in a single Physics/SolidMechanics/QuasiStatic with the generalized_plain_.. strain parameters) is nicer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GiudGiud can you point me to the test case you tried this on? I can take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modules/solid_mechanics/test/tests/generalized_plane_strain/generalized_plane_strain_squares.i
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bwspenc , @GiudGiud - i have been away on holidays, but am back to work now. Is there anything i need to do to progress this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check if there is a way to make this syntax work
without using the deprecated
Kernels/SolidMechanicssyntax, but with the Physics syntax insteadPhysics/SolidMechanics/QuasiStaticI imagine not. I imagine the only way is with the manual
Kernelsdefinition or theKernels/SolidMechanicsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @GiudGiud , i hope to do that in the next 7 hours, and will report back here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GiudGiud ,
I believe it is possible, with input files along the lines of:
However, this frequently gives EXODIFFs because of some changes between the old and new Actions. Eg, using
Problem/type=DumpObjectsProblemfor the filetest/tests/generalized_plane_strain/generalized_plane_strain_squares.ireveals the following changes:OLD:
NEW (with the QuasiStatic Physics) also includes
eigenstrain_names = eigenstrain.OLD:
NEW also includes
temperature = tempand hasuse_displaced_mesh = falseOLD:
NEW has
use_displaced_mesh = false.I feel uncomfortable making changes with gold files, and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bwspenc thoughts?
I think what we have here works.
It's either physics syntax with the unique way of setting it up, or manual kernels + materials syntax. None of the options in between (Kernels/SolidMechanics or one physics for GeneralizedPlainStrain and one for QuasiStatic) are sanctioned (either deprecated or slightly wrong)