-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
T: taskAn enhancement to the software.An enhancement to the software.
Description
Motivation
Current Thermochimica naming can cause two practical problems:
- Name collisions when multiple
ChemicalCompositionblocks use overlapping elements (e.g. both needCr). - Hardcoded
:separator in output names (mu:Na,gas_ideal:NiCl2, etc.), which may conflict with user conventions and downstream tooling.
Design
1) Prefix for generated variables
- New parameter:
prefix - If non-empty and missing trailing
_,_is appended. - Prefix is applied to all variables generated by the action (elements and Thermochimica outputs).
- Example:
prefix = salt->salt_Cr,salt_mu:Cr, etc.
2) Configurable output separator
- New parameter:
output_name_separator - MooseEnum values:
colon(default, backward-compatible)slashunderscore
- Affects parsing,
ALLexpansion, and generated/coupled names for:output_speciesoutput_element_potentialsoutput_vapor_pressuresoutput_element_phases
- Strict mode by selection: if separator is
slashorunderscore, colon-formatted entries are rejected.
Impact
This issue tracks improvements to ChemicalComposition variable naming for Thermochimica workflows:
- Prefix support for generated variables (already implemented)
- Configurable output-name separator for Thermochimica output variables (already implemented)
Together, these changes let users avoid variable-name collisions and choose output token separators beyond :. Default behavior remains fully backward compatible (output_name_separator=colon).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
T: taskAn enhancement to the software.An enhancement to the software.