feat: support "Format on Paste" #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idahogurl
commented
Apr 22, 2023
Comment on lines
+30
to
+33
| const startLine = document.lineAt(0); | ||
| const endLine = document.lineAt(document.lineCount - 1); | ||
| const range = new Range(startLine.range.start, endLine.range.end); | ||
|
|
Owner
Author
There was a problem hiding this comment.
Create range for entire document not just for the selected text.
idahogurl
commented
Apr 22, 2023
Comment on lines
-45
to
+50
| provideDocumentRangeFormattingEdits(document, range) { | ||
| return formatter(document, range); | ||
| provideDocumentRangeFormattingEdits(document) { | ||
| return formatter(document); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
What
Format on Pasteuses the registeredDocumentRangeFormattingEditProviderfor formatting. Instead of providing the range for the entire document, it provides the range for the pasted text. This causes semi-colons and commas to be inserted becausepretter-eslintonly supports formatting the entire document.How
Create range using document line count instead of using provided range