Skip to content

Conversation

@Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Jan 24, 2019

CompressionMethod.BZip is curently defined as 11, but it seems that it should actually be 12

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@Numpsy Numpsy changed the title Change value of CompressionMethod.Bzip from 11 to 12 Change value of CompressionMethod.Bzip2 from 11 to 12 Jan 24, 2019
@piksel
Copy link
Member

piksel commented Jan 25, 2019

As per APPPNOTE.TXT:4.4.5, 11 is reserved and 12 is BZip2
(as a clarification for what "should" refers to)

@piksel piksel merged commit 4f541a4 into icsharpcode:master Jan 26, 2019
@Numpsy Numpsy deleted the bzip_method branch January 26, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants