writing correct Tar UTF8 filenames #182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I have been going through how the tar headers are parsed for #121, and UTF-8 encoded names is probably better. The specification suggests using extended headers for encodings other than ASCII, but GNU Tar writes the UTF8-encoded bytes as the |
piksel
added a commit
to piksel/SharpZipLib
that referenced
this pull request
Jul 1, 2018
piksel
reviewed
Jun 15, 2019
| int i; | ||
|
|
||
| for (i = 0; i < length && nameOffset + i < name.Length; ++i) | ||
| byte[] nameBytes = Encoding.UTF8.GetBytes(name); |
Member
There was a problem hiding this comment.
I doubt we want BOMs in the name
Suggested change
| byte[] nameBytes = Encoding.UTF8.GetBytes(name); | |
| byte[] nameBytes = new Encoding.UTF8Encoding(false).GetBytes(name); |
Contributor
|
This PR's implementation may cut the filename which has long length(over 100 bytes in UTF-8) + non-ascii character because char above U+80 is not one byte in UTF-8. |
Contributor
|
Is this obsoleted by #364 being merged? |
Member
|
Indeed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the problem of writing UTF8 Filenames within a Tar correctly. I didn't consider reading so far.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.