Fix #217: uvx pptagent onboard 启动失败#222
Merged
Force1ess merged 5 commits intoicip-cas:mainfrom Apr 6, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #217
Describe your changes
Moves the
deeppresenter.tui.appanddeeppresenter.tui.controllerimports from module-level indeeppresenter/cli/commands.pyto lazy imports inside thetui()function body. Previously, these two imports were evaluated at module load time (lines 20–21), which caused aModuleNotFoundErrorwhenever any CLI command (onboard,generate,serve, etc.) was invoked in environments where thedeeppresenter.tuisubpackage was absent or not yet installed. By deferring the imports to the point of use insidetui(), all other commands load successfully regardless of whether the TUI dependencies are present.Adds
deeppresenter/test/test_cli_commands.pywith a test (test_tui_not_imported_at_module_level) that parsescommands.pyvia theastmodule and asserts no top-levelImportFromnodes referencedeeppresenter.tui, preventing regression.Issue ticket number and link
Issue #217: #217
Checklist before requesting a review
This PR was created with AI assistance (Claude). The changes were reviewed by quality gates and a critic model before submission.