Skip to content

Prioritize Shrink over Fill#3045

Merged
hecrj merged 3 commits intomasterfrom
limits-compression
Aug 29, 2025
Merged

Prioritize Shrink over Fill#3045
hecrj merged 3 commits intomasterfrom
limits-compression

Conversation

@hecrj
Copy link
Member

@hecrj hecrj commented Aug 29, 2025

This PR makes a Fill inside a Shrink behave as if it was Shrink.

Effectively, this allows controlling and overriding Fill behavior from a higher level container widget.

As a consequence, scrollable can now handle Fill content by simply forcing it to behave as Shrink; so it will no longer panic in debug mode.

@hecrj hecrj added this to the 0.14 milestone Aug 29, 2025
@hecrj hecrj added improvement An internal improvement layout change labels Aug 29, 2025
@hecrj hecrj enabled auto-merge August 29, 2025 01:48
@hecrj hecrj merged commit caeb9ce into master Aug 29, 2025
30 checks passed
@hecrj hecrj deleted the limits-compression branch August 29, 2025 01:55
@abique
Copy link

abique commented Aug 29, 2025

With the following scenario:

A row with one widget fixed height 150, and another widget that has a fill height.
What do you set on the row to make the second widget reach the height 150? Before I'd set shrink height on the row and that'd work. Now it is broken it seems.

Is that a bug?

@abique
Copy link

abique commented Aug 29, 2025

Fixed by 9994f1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change improvement An internal improvement layout

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants