Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches our
deviatelogic during palette generation to use Oklch instead of HSL; improving perceived contrast consistency between themes (specially when comparing light and dark variants).I noticed Oklch tends to produce gray colors; so I have introduced a "chromatic bump" to make them more colorful and bring out their particular personality. I suspect the math is wrong in many ways, but this is art so who cares.
Additionally, it introduces
weakerandstrongerbackground variants. These represent a shade betweenweakestandweak, andstrongandstrongest; respectively.Finally, this PR also enables the
crispfeature by default. I've been running it in my personal projects with good results and I believe the enhanced clarity makes up for the potential drawbacks.